Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow detectOpenHandles in jest.config.js #6747

Closed
wants to merge 3 commits into from

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Jul 24, 2018

Summary

Current if config detectOpenHandles in jest.config.js, validation warning will be thrown:

● Validation Warning:
Unknown option "detectOpenHandles" with value true was found.
This is probably a typing mistake. Fixing it will remove this message.

Resolve warning in nuxt/nuxt#3581

@mattphillips
Copy link
Contributor

LGTM! @clarkdo could you add an entry to the changelog?

@SimenB
Copy link
Member

SimenB commented Aug 9, 2018

As mentioned in another issue (on mobile, so hard to dig up), detectOpenHandles was intentionally not added to config - the performance overhead is pretty bad (30+%). Once the performance overhead is gone (or reduced enough) we'll remove the flag as well and make the behavior the default

@clarkdo
Copy link
Contributor Author

clarkdo commented Aug 9, 2018

@mattphillips Done

@codecov-io
Copy link

Codecov Report

Merging #6747 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6747   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files         235      235           
  Lines        9112     9112           
  Branches        4        4           
=======================================
  Hits         5781     5781           
  Misses       3330     3330           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/valid_config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7eead1...ebcc568. Read the comment docs.

@manniL
Copy link

manniL commented Sep 30, 2018

The related comment that @SimenB mentioned: #6130 (comment)

@reuveniy
Copy link

Would love to see this goes in @clarkdo

@rickhanlonii
Copy link
Member

@SimenB if we document the performance hit, would you be ok to add this to the config?

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants